Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] magento/magento2#12194: Tier price on configurable product sorting so… #20642

Merged
merged 2 commits into from
Feb 4, 2019
Merged

[Backport] magento/magento2#12194: Tier price on configurable product sorting so… #20642

merged 2 commits into from
Feb 4, 2019

Conversation

amol2jcommerce
Copy link
Contributor

…metimes-wrong

Description (*)

Fixed Issues (if relevant)

  1. Tier price on configurable product sorting sometimes wrong #20407
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4015 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit 25f2311 into magento:2.2-develop Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 4, 2019
@sidolov
ENGCOM-4015: [Backport] #12194: Tier price on configurable product so…
12e4ec2 
…rting so… #20642
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Component: Catalog Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
6 participants
@amol2jcommerce @magento-engcom-team @sidolov @okorshenko @vshatylo @p-bystritsky